fix(material/timepicker): unable to reopen if closed by scroll strategy #30561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timepicker wasn't updating its internal state when it gets closed through the overlay which meant that the user can't reopen it. Fixes angular#30558.
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
wagnermaciel
approved these changes
Feb 27, 2025
|
The changes were merged into the following branches: main, 19.2.x |
1 task
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 6, 2025
angular#30561 accidentally switched the default scroll strategy for the timepicker to be `close` instead of `reposition`. It was unintentional so these changes switch it back to `reposition`.
crisbeto
added a commit
that referenced
this pull request
Mar 6, 2025
#30561 accidentally switched the default scroll strategy for the timepicker to be `close` instead of `reposition`. It was unintentional so these changes switch it back to `reposition`.
crisbeto
added a commit
that referenced
this pull request
Mar 6, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timepicker wasn't updating its internal state when it gets closed through the overlay which meant that the user can't reopen it.
Fixes #30558.